Here's my take, which is different from what is below.
It depends on what kind of vacation you want.
My 1st trip I stayed in Waikiki. I couldn't afford to be on the beach so we were about 5 blocks away. With just my husband and I, this was totally do-able. And it was nice to have restaurants within walking distance for dinner in the evening. These were the positives. The negatives were that in some ways, a city is a city (IMO). It's crowded - the beach here is very crowded. And if I forgot something in the room, it was a hassle to go back and get it. Even though we could walk to the beach and to dinner, we still felt like we needed a rental car because we wanted to drive to some snorkeling beaches, to see the north shore, Arizona memorial, etc. We did have a great time though.
For our second trip, which was this past fall and included our 2 kids (ages 3 and 7 at the time), we stayed in Ko 'Olina. We stayed in a resort on the beach for the same price as a hotel off the beach in Waikiki (actually got a 2 room suite for the same price as a single hotel room in Waikiki). And, when the kids forgot something, or wanted a snack, or just needed a little break, we could easily run back to the room. The beach was never crowded. Our resort hotel had a pool for when the kids wanted a break from the beach, because little kids can't really swim in the ocean, the waves are to tough for them. For dinner, we went to the next little town over, which had a lot of family-friendly restaurants. The only negative was that we had drive to dinner every night, we couldn't walk (unless we wanted to eat in the expensive resort hotel; we chose not to).
Overall, my recommendation is that for a family vacation, go to Ko'Olina. If it's just you and your 'other', then pick Ko'Olina if you want uncrowded beaches. Or pick Waikiki if you want a city and nightlife and you can afford to stay on the beach.
In Ko'Olina, we stayed at a Marriott Beach Club. It is nice and I highly recommend it. It is next door to the Disney Resort. The Disney Resort is GORGEOUS (it's in a Polynesian theme, not a typical Disney theme). It's expensive, but if you can afford it - wow is it awesome.